-
Notifications
You must be signed in to change notification settings - Fork 1
0002: Add usecases #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: add-permission-architecture
Are you sure you want to change the base?
Conversation
Add UC from inventree/InvenTree#7466 (comment)
|
@SergeoLacruz I have created this PR to add the use cases you proposed; I have some questions, which I will add as comments |
| ### UC2: Harold is working in the purchasing department | ||
| (1) He adds suppliers and their prices to the parts. | ||
| (2) But he cannot modify the parts or the parameters. | ||
| (3) He can also create and edit purchase orders. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can harold issue purchase orders?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes he can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this would be correct?
| ### UC2: Harold is working in the purchasing department | |
| (1) He adds suppliers and their prices to the parts. | |
| (2) But he cannot modify the parts or the parameters. | |
| (3) He can also create and edit purchase orders. | |
| ### UC2: Harold is working in the purchasing department | |
| (1) He adds suppliers and their prices to the parts. | |
| (2) But he cannot modify the parts or the parameters. | |
| (3) He can also create, edit and issue purchase orders. |
| ### UC5: Max is a tester working on the Astro project | ||
| (1) He can add and modify test results to all parts related to the Astro project. | ||
| (2) He can also see the results from the Moonshot project for comparison but he cannot edit them. | ||
| (3) When Max goes on vacation for two weeks he introduces Oliver as his deputy who usually works on Moonshot. For the time of Max vacation Oliver can edit Moonshot and Astro parts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is to complex, I would like to remove this @SergeoLacruz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. This wound add a time dependent access rule. Deputies can also manually be added by an admin for vacation time. It is nice but not really required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we can remove this? We do not have the concept of deputies in the system right now and I think that should be a separate discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| (3) When Max goes on vacation for two weeks he introduces Oliver as his deputy who usually works on Moonshot. For the time of Max vacation Oliver can edit Moonshot and Astro parts. |
|
|
||
| ### UC6: Bruce is working in the warehouse. | ||
| (1) He can shuffle around stock items and boxes between locations. | ||
| (2) But he cannot create new locations. This is up to Marvin who makes the floor plan of the warehouse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need a separate UC for Marvin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warehouse floor plan design. I am not sure if we really need this. Sometimes even Bruce creates a new location like Box 138 for delivery to xyz. Lets delete line 161 for the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| (2) But he cannot create new locations. This is up to Marvin who makes the floor plan of the warehouse. |
| (2) But he cannot create new locations. This is up to Marvin who makes the floor plan of the warehouse. | ||
|
|
||
| ### UC7: Mike works in the factory. | ||
| (1) He can create parts that are manufactured, add serial numbers, and other data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which other data @SergeoLacruz ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g. manufacturing comments like "done rework on R34". Do we have those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, not at the moment. So can we change this to
| (1) He can create parts that are manufactured, add serial numbers, and other data. | |
| (1) He can create parts that are manufactured, add serial numbers and tests. |
|
|
||
| ### UC7: Mike works in the factory. | ||
| (1) He can create parts that are manufactured, add serial numbers, and other data. | ||
| (2) But he cannot add or modify parts for design as Marcus can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SergeoLacruz How would the system decipher which part is for design? Probably most parts are for design
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mhhhh... Good question.
All R, C, L, ... are for design. Those are created by libarians
Manufactured parts are the product.
But you are right, I do not see a good method to distinguish between them in the actual system.
I need to think about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think this is a complexity that should be handled in core and would remove this line
| (2) But he cannot add or modify parts for design as Marcus can. |
Add UC from inventree/InvenTree#7466 (comment)