-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[messaging] Enhance Expo notification icon configuration support and documentation #8618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Co-authored-by: Ehesp <[email protected]>
Co-authored-by: Ehesp <[email protected]>
Co-authored-by: Ehesp <[email protected]>
(Playing around, ignore) |
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
this is an actual issue though - was just slightly lower priority but I did want to check it out |
Summary
This PR addresses issue #8616 by significantly improving the documentation and developer experience for the existing Expo notification icon configuration feature in @react-native-firebase/messaging.
The messaging package already includes an Expo config plugin (added in v18.7.0 via #7369) that automatically configures Firebase notification icons and colors from
app.json
, but this functionality was poorly documented and largely unknown to users.Changes Made
📚 Enhanced Documentation
docs/messaging/usage/index.md
with comprehensive Expo configuration section including:app.json
configurationpackages/messaging/README.md
with clear Expo setup instructions and examplepackages/messaging/EXPO_EXAMPLE.md
with detailed examples and best practices🔧 Improved Developer Experience
[@react-native-firebase/messaging]
✅ Enhanced Testing
How It Works
The existing Expo plugin automatically:
expo.notification.icon
andexpo.notification.color
fromapp.json
com.google.firebase.messaging.default_notification_icon
com.google.firebase.messaging.default_notification_color
Example Configuration
Before vs After
Before: Users were unaware this feature existed and requested it as a new feature
After: Clear documentation and improved messaging make the feature discoverable and easy to use
Testing
This PR transforms an existing but hidden feature into a well-documented, user-friendly solution that fully addresses the feature request in #8616.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
docs.expo.dev
curl -s REDACTED
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.