Skip to content

feat(ui):Manage model switching and error states #8177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

hipsterusername
Copy link
Member

Summary

Switches IP adapter models to the first matching model for the architecture.

Related Issues / Discussions

Discussions

QA Instructions

Switch between different models and confirm it works

Merge Plan

Merge at will.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added the frontend PRs that change frontend files label Jul 2, 2025
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some small fixes. It occurred to me that if we are gonna do this for ref images, we should probably also do it for control layers, right?

@hipsterusername
Copy link
Member Author

I can go either way - Ref Images controls are just collapsed/hidden by default. the challenge is that there are diff control layer modes and you might have a pre-processed image

@hipsterusername hipsterusername force-pushed the cursor/manage-model-switching-and-error-states-8a4e branch from 186687e to f2cc3a1 Compare July 8, 2025 03:57
cursoragent and others added 17 commits July 8, 2025 00:01
* initializing prompt expansion and putting response in prompt box working for all methods

* properly disable UI and show loading state on prompt box when there is a pending prompt expansion item

* misc wrapup: disable apploying prompt templates, dont block textarea resize handle

* update progress to differentiate between prompt expansion and non

* cleanup

* lint

* more cleanup

* add image to background of loading state

* add allowPromptExpansion for front-end gating

* updated readiness text for needing to accept or discard

* fix tsc

* lint

* lint

* refactor(ui): prompt expansion logic

* tidy(ui): remove unnecessary changes

* revert(ui): unused arg on useImageUploadButton

* feat(ui): simplify prompt expansion state

* set pending for dragndrop and context menu

* add readiness logic for generate tab

* missing translation

* update error handling for prompt expansion

---------

Co-authored-by: Mary Hipp <[email protected]>
Co-authored-by: Mary Hipp <[email protected]>
Co-authored-by: psychedelicious <[email protected]>
@github-actions github-actions bot added CI-CD Continuous integration / Continuous delivery api python PRs that change python files invocations PRs that change invocations backend PRs that change backend files services PRs that change app services frontend-deps PRs that change frontend dependencies labels Jul 8, 2025
@hipsterusername
Copy link
Member Author

Think im going to burn this PR down and restart. Didn't like the rebase

@hipsterusername hipsterusername deleted the cursor/manage-model-switching-and-error-states-8a4e branch July 10, 2025 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api backend PRs that change backend files CI-CD Continuous integration / Continuous delivery frontend PRs that change frontend files frontend-deps PRs that change frontend dependencies invocations PRs that change invocations python PRs that change python files services PRs that change app services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants