Skip to content

spread custom components for combobox with those passed in #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

spread custom components for combobox with those passed in #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a58a513
spread custom components with those passed in
Sep 18, 2024
6347956
remove components from the rest
Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/components/combobox/combobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,13 @@ const styles: StylesConfig<ComboboxOption> = {
menuPortal: (provided) => ({ ...provided, zIndex: 9999 }),
};

const components: SelectComponentsConfig<ComboboxOption, false, GroupBase<ComboboxOption>> = {
const componentOverrides: SelectComponentsConfig<ComboboxOption, false, GroupBase<ComboboxOption>> = {
Option: CustomOptionComponent,
MenuList: CustomMenuListComponent,
};

export const Combobox = typedMemo((props: ComboboxProps) => {
const { sx, selectRef, inputRef, ...rest } = props;
const { sx, selectRef, inputRef, components, ...rest } = props;
const chakraStyles = useMemo<CustomChakraStylesConfig>(
() => ({
container: (provided, _state) => ({ ...provided, w: 'full', ...sx }),
Expand Down Expand Up @@ -75,7 +75,7 @@ export const Combobox = typedMemo((props: ComboboxProps) => {
menuPortalTarget={document.body}
colorScheme="base"
selectedOptionColorScheme="base"
components={components}
components={{...componentOverrides, ...components}}
chakraStyles={chakraStyles}
styles={styles}
variant="filled"
Expand Down