Fix TypeError in BlockParser::parseDate with fallback regex #231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #220
The issue is that sometimes the WHOIS output contains the same key multiple times in places where it's not expected.
One particular domain name I had this issue with had WHOIS output looking like this:
The
ParserHelper::linesToGroups
function turns this structure into something like this (formatted as YAML here):Turning duplicate keys into an array is more or less expected, because duplicate keys are common and sometimes different, and then all values are relevant (i.e. the
Name Server
key).The date parser assumes that all keys it gets are single keys, but that's not the case here, and that's what causes it to break.