-
Notifications
You must be signed in to change notification settings - Fork 27
Nginx websocket fix #1135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nginx websocket fix #1135
Conversation
Had the same issue today, that the connection via nginx is not working. The websocket config was not complete. The proposed solution works for me! |
@Avarios do you mind working through the checklist? @AlCalzone are there any concerns from your side or can we bring it to master? |
The changes look reasonable to me. If it is working, then the only thing left to do is to complete the PR checklist. Once this is done and all checks are green, I can merge this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plus what the others said.
CHANGELOG.md
Outdated
@@ -5,6 +5,10 @@ | |||
## __WORK IN PROGRESS__ | |||
(at the beginning of a new line) | |||
--> | |||
|
|||
## __WORK IN PROGRESS__ | |||
* (Avarios) Updatet devcontainer template NGINX : Replaced socket.io with @websocket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs a migration guide for users who want to modify their existing setups.
Hi all, ill need two more weeks for this, it is not forgotten my time is very limited :D |
I have included your fix in #1137 where I have completed documentation an checklist already. |
Cool, less work for me :D Thank you |
Co-authored-by: AlCalzone <[email protected]>
Co-authored-by: AlCalzone <[email protected]>
Co-authored-by: AlCalzone <[email protected]>
Ok, then I close here in favor of #1137 |
PR Checklist:
npm run build
npm test
.github/create_templates.ts
)docs/updates
explaining what the user needs to do when manually updating an existing projectCHANGELOG.md
(referencing the migration description and this PR or the issue you fixed)Description:
In the current Version the dev container is spinning up a NGINX.
IOBroker is using WebSockets for some Operations but with the current config, it fails to reach the websocket.
With my change, the websocket connection is reachable again