Skip to content

Conversation

Avarios
Copy link

@Avarios Avarios commented Mar 15, 2025

PR Checklist:

  • Provide a meaningful description to this PR or mention which issues this fixes.
  • Ensure the project builds with npm run build
  • Add tests for your change. This includes negative tests (i.e. inputs that need to fail) as well as baseline tests (i.e. how should the directory structure look like?).
  • Run the test suite with npm test
  • If there are baseline changes, review them and make a separate commit for them with the comment "accept baselines" if they are desired changes
  • If you added a required option, also add it to the template creation (.github/create_templates.ts)
  • Add a detailed migration description to docs/updates explaining what the user needs to do when manually updating an existing project
  • Add your changes to CHANGELOG.md (referencing the migration description and this PR or the issue you fixed)

Description:
In the current Version the dev container is spinning up a NGINX.
IOBroker is using WebSockets for some Operations but with the current config, it fails to reach the websocket.
With my change, the websocket connection is reachable again

@hacki11
Copy link

hacki11 commented Apr 1, 2025

Had the same issue today, that the connection via nginx is not working. The websocket config was not complete.

The proposed solution works for me!

@hacki11
Copy link

hacki11 commented Apr 10, 2025

@Avarios do you mind working through the checklist? @AlCalzone are there any concerns from your side or can we bring it to master?

@UncleSamSwiss
Copy link
Collaborator

The changes look reasonable to me. If it is working, then the only thing left to do is to complete the PR checklist. Once this is done and all checks are green, I can merge this PR.

Copy link
Collaborator

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus what the others said.

CHANGELOG.md Outdated
@@ -5,6 +5,10 @@
## __WORK IN PROGRESS__
(at the beginning of a new line)
-->

## __WORK IN PROGRESS__
* (Avarios) Updatet devcontainer template NGINX : Replaced socket.io with @websocket
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs a migration guide for users who want to modify their existing setups.

@hacki11 hacki11 mentioned this pull request Apr 12, 2025
8 tasks
@Avarios
Copy link
Author

Avarios commented May 9, 2025

Hi all, ill need two more weeks for this, it is not forgotten my time is very limited :D

@hacki11
Copy link

hacki11 commented May 9, 2025

Hi all, ill need two more weeks for this, it is not forgotten my time is very limited :D

I have included your fix in #1137 where I have completed documentation an checklist already.

@Avarios
Copy link
Author

Avarios commented May 9, 2025

Hi all, ill need two more weeks for this, it is not forgotten my time is very limited :D

I have included your fix in #1137 where I have completed documentation an checklist already.

Cool, less work for me :D Thank you

@Apollon77
Copy link
Collaborator

Ok, then I close here in favor of #1137

@Apollon77 Apollon77 closed this Aug 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants