Skip to content

fix(reorder-group): add children fallback for framework compatibility #30593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: test/migrate-angular-playwright
Choose a base branch
from

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Aug 1, 2025

Issue number: resolves #30592


What is the current behavior?

Reorder group is failing for Angular, React & Vue due to the change from children to __children.

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 8.7.2-dev.11754087334.1815cf22

Copy link

vercel bot commented Aug 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2025 10:54pm

@github-actions github-actions bot added the package: core @ionic/core package label Aug 1, 2025
@github-actions github-actions bot added the package: angular @ionic/angular package label Aug 2, 2025
@brandyscarney brandyscarney changed the base branch from main to test/migrate-angular-playwright August 2, 2025 19:24
@brandyscarney brandyscarney changed the title fix(reorder-group): fallback to children if __children is undefined fix(reorder-group): add children fallback for framework compatibility Aug 4, 2025
@brandyscarney brandyscarney marked this pull request as ready for review August 4, 2025 19:07
@brandyscarney brandyscarney requested a review from a team as a code owner August 4, 2025 19:07
@brandyscarney brandyscarney requested review from gnbm and removed request for a team August 4, 2025 19:07
@github-actions github-actions bot added package: vue @ionic/vue package package: react @ionic/react package labels Aug 4, 2025
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, and great work on regression tests 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: in React, clicking to reorder an item in IonReorder gives TypeError: undefined is not an object
2 participants