Skip to content

continuation of use string instead of struct backing #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Sep 12, 2018
Merged

continuation of use string instead of struct backing #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e153340
feat: use CIDs as their byte representation instead of a struct
dignifiedquire May 3, 2018
92496b5
use string instead of []byte as underlying store
dignifiedquire May 3, 2018
8009448
fix KeyString()
dignifiedquire May 3, 2018
d7974d2
Export version() method, various other code cleanups.
kevina Aug 25, 2018
9831436
Change string representation to represent actual binary representation.
kevina Aug 25, 2018
b5a08dc
Change EmptyCid to just Nil.
kevina Aug 25, 2018
cad5216
Ensure we always have a valid Cid by hiding the type in a struct.
kevina Aug 25, 2018
426ebe9
Simplify assignment in UnmarshalJSON.
kevina Aug 25, 2018
667c6a9
Avoid allocating memory in Type() method.
kevina Aug 25, 2018
e0a5698
Add IsNil() method.
kevina Aug 29, 2018
440a1c1
Removed description of layout of CID as it is not correct for CIDv0.
kevina Aug 30, 2018
7b4617f
Eliminate unnecessary copy of Cid now that its an immutable string.
kevina Sep 1, 2018
643f78a
Change 'IsNil' method to 'Defined'.
kevina Sep 5, 2018
67a2bcf
Change 'Nil' constant to 'Undef'.
kevina Sep 5, 2018
46dd393
Handel undefined Cid is JSON representation.
kevina Sep 7, 2018
dfc48d3
Make sure we have a SHA2_256, length 32 hash when creating a CidV0.
kevina Sep 10, 2018
f003360
Gx update go-multibase.
kevina Sep 11, 2018
6e296c5
gx publish 0.9.0
kevina Sep 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gx/lastpubver
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.8.0: QmZFbDTY9jfSBms2MchvYM9oYRbAF19K7Pby47yDBfpPrb
0.9.0: QmPSQnBKM9g7BaUcZCvswUJVscQ1ipjmwxN5PXCjkp9EQ7
10 changes: 5 additions & 5 deletions builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
)

type Builder interface {
Sum(data []byte) (*Cid, error)
Sum(data []byte) (Cid, error)
GetCodec() uint64
WithCodec(uint64) Builder
}
Expand Down Expand Up @@ -33,10 +33,10 @@ func (p Prefix) WithCodec(c uint64) Builder {
return p
}

func (p V0Builder) Sum(data []byte) (*Cid, error) {
func (p V0Builder) Sum(data []byte) (Cid, error) {
hash, err := mh.Sum(data, mh.SHA2_256, -1)
if err != nil {
return nil, err
return Undef, err
}
return NewCidV0(hash), nil
}
Expand All @@ -52,14 +52,14 @@ func (p V0Builder) WithCodec(c uint64) Builder {
return V1Builder{Codec: c, MhType: mh.SHA2_256}
}

func (p V1Builder) Sum(data []byte) (*Cid, error) {
func (p V1Builder) Sum(data []byte) (Cid, error) {
mhLen := p.MhLength
if mhLen <= 0 {
mhLen = -1
}
hash, err := mh.Sum(data, p.MhType, mhLen)
if err != nil {
return nil, err
return Undef, err
}
return NewCidV1(p.Codec, hash), nil
}
Expand Down
Loading