feat(routing/http): return 200 for empty results per IPIP-513 #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes: - server returns 200 instead of 404 for empty results - providers: empty JSON/NDJSON array - peers: empty JSON/NDJSON array - ipns: text/plain "Record not found" - client handles both 200 and 404 responses for backward compatibility - client handles null/undefined Providers/Peers fields test coverage: - added tests for 404 backward compatibility (old servers) - added tests for null/undefined field handling - added tests for IPNS content-type validation - test fixtures use special CIDs to trigger edge cases
lidel
changed the title
lidel
force-pushed
the
feat/ipip-513-empty-200s
branch
from
53b7481 to
1459f1d
Compare
achingbrain
reviewed
Oct 13, 2025
| const peerCid = CID.parse(cidStr) | ||
| peerId = peerIdFromCID(peerCid) | ||
| } catch (err) { | ||
| } catch (err: any) { |
There was a problem hiding this comment.
I think : any has been added here to mask a TypeScript error. The error is valid - fastify's pino logger doesn't log additional arguments without formatters and the types have been updated to reflect this, causing the error where there wasn't one before.
The correct solution is either to add a formatter:
fastify.log.error('could not parse CID from params - %s', err)
or pass the error as a merging object:
fastify.log.error({ err }, 'could not parse CID from params')
The latter is probably better as depending on the Error implementation we can lose information during stringification.
Docs link: https://github.com/pinojs/pino/blob/main/docs/api.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements IPIP-513 spec changes for delegated routing v1 endpoints to return 200 with empty results instead of 404 + some extra fixes to ensure client interop with broad type of servers.
changes
test coverage
Notes & open questions
Change checklist