fix: skip DNSLink resolution when offline, deduplicate inflights #1339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #1337 - removed hardcoded fallback to https://ipfs.io when offline - switched from deprecated /api/v0/name/resolve to /api/v0/resolve - use POST method for RPC API calls (not GET) - return undefined when offline to avoid caching false negatives - prevent privacy leak by not sending requests to external services
- added in-flight request tracking with pendingLookups Map - prevents multiple simultaneous API calls for the same FQDN - reduces redundant requests from 2-4 down to 1 per domain - improves performance on initial page load with empty cache
store promise after invocation to prevent race where finally block could execute before promise is stored in pendingLookups Map addresses #1339 (comment)
clarifies the three possible return values and their semantics as requested in review addresses #1339 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: remove ipfs.io fallback in DNSLink resolution
undefinedwhen offline to avoid caching false negativesfix: deduplicate concurrent DNSLink lookups for same domain