Pw/chen #300
Open
Pw/chen #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. each component should extend base component
3. base component should extend base element
…, and move it to base
AndyKIron
approved these changes
Apr 15, 2024
Member
AndyKIron
left a comment
AndyKIron
left a comment
There was a problem hiding this comment.
Changes on "projects/fusion-ui" approved
projects/fusion-ui/components/chart-labels/v4/chart-labels-v4.component.ts
Outdated
Show resolved
Hide resolved
NoaMartan
suggested changes
Apr 16, 2024
projects/fusion-e2e/entities/tests/include-exclude/include-exclude.ts
Outdated
Show resolved
Hide resolved
projects/fusion-e2e/entities/components/chip-filter/chipFilter-component.ts
Outdated
Show resolved
Hide resolved
projects/fusion-e2e/entities/components/chip-filter/chipFilter-component.ts
Outdated
Show resolved
Hide resolved
NoaMartan
suggested changes
Apr 17, 2024
projects/fusion-e2e/entities/components/inputs/input-v4/inputs-component.ts
Show resolved
Hide resolved
NoaMartan
reviewed
Apr 18, 2024
# Conflicts: # package-lock.json # projects/fusion-ui/components/chart-labels/v4/chart-labels-v4.component.html # projects/fusion-ui/components/chart-labels/v4/chart-labels-v4.component.ts # projects/fusion-ui/components/chart/v4/stories/chart-v4-story-wrapper.component.ts
# Conflicts: # package-lock.json
# Conflicts: # package-lock.json # package.json # projects/fusion-ui/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.