Completing ROS Simulation Control #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… : GetEntityBounds
|
Thank you for the suggestion, we will work on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I know that, according to your contribution guidelines, you can't directly accept pull requests. So this should be taken as a feature idea.
First of all, I think adding this new extension, ROS2 Simulation Control, is a great idea and a significant step towards a seamless ROS2 workflow.
I noticed that not all of the services proposed by the Simulation Control package have been implemented.
Here is one I implemented for my own purpose, but I think GetEntityBounds is an important service (for collision detection, etc.).
Of course, it has to be improved — for instance, by supporting more complex bounding shapes (such as convex hulls).
Thank you,