Fix ztunnel version enumeration in update-version-list script #1416

sridhargaddam · 2025-12-01T12:18:22Z

This PR includes the following changes.

Fixes an issue where the ZTunnel CRD included v1.25-latest and v1.24-latest.
Updates hack/update-version-list.sh so ztunnelversionsEnum is derived from versionsEnum while filtering out v1.21.x, v1.22.x, and v1.23.x.
Adds chart/samples/ztunnel-sample.yaml to updateVersionInSamples to keep all sample files in sync with version updates.

sridhargaddam · 2025-12-01T12:22:16Z

The code is good for review. I've added "/hold" so that @dgn would get a chance to review the PR before merging.

codecov · 2025-12-01T12:22:41Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.64%. Comparing base (43234a9) to head (bc4241f).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1416      +/-   ##
==========================================
- Coverage   80.77%   80.64%   -0.14%     
==========================================
  Files          44       44              
  Lines        2299     2299              
==========================================
- Hits         1857     1854       -3     
- Misses        324      327       +3     
  Partials      118      118

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sridhargaddam · 2025-12-01T12:21:39Z

api/v1/ztunnel_types.go

-	// +kubebuilder:validation:Enum=v1.28-latest;v1.28.0;v1.27-latest;v1.27.3;v1.27.2;v1.27.1;v1.27.0;v1.26-latest;v1.26.6;v1.26.5;v1.26.4;v1.26.3;v1.26.2;v1.26.1;v1.26.0;v1.25-latest;v1.24-latest;master;v1.29-alpha.b2f713a9
+	// Must be one of: v1.28-latest, v1.28.0, v1.27-latest, v1.27.3, v1.27.2, v1.27.1, v1.27.0, v1.26-latest, v1.26.6, v1.26.5, v1.26.4, v1.26.3, v1.26.2, v1.26.1, v1.26.0, master, v1.29-alpha.b2f713a9.
+	// +operator-sdk:csv:customresourcedefinitions:type=spec,order=1,displayName="Istio Version",xDescriptors={"urn:alm:descriptor:com.tectonic.ui:fieldGroup:General", "urn:alm:descriptor:com.tectonic.ui:select:v1.28-latest", "urn:alm:descriptor:com.tectonic.ui:select:v1.28.0", "urn:alm:descriptor:com.tectonic.ui:select:v1.27-latest", "urn:alm:descriptor:com.tectonic.ui:select:v1.27.3", "urn:alm:descriptor:com.tectonic.ui:select:v1.27.2", "urn:alm:descriptor:com.tectonic.ui:select:v1.27.1", "urn:alm:descriptor:com.tectonic.ui:select:v1.27.0", "urn:alm:descriptor:com.tectonic.ui:select:v1.26-latest", "urn:alm:descriptor:com.tectonic.ui:select:v1.26.6", "urn:alm:descriptor:com.tectonic.ui:select:v1.26.5", "urn:alm:descriptor:com.tectonic.ui:select:v1.26.4", "urn:alm:descriptor:com.tectonic.ui:select:v1.26.3", "urn:alm:descriptor:com.tectonic.ui:select:v1.26.2", "urn:alm:descriptor:com.tectonic.ui:select:v1.26.1", "urn:alm:descriptor:com.tectonic.ui:select:v1.26.0", "urn:alm:descriptor:com.tectonic.ui:select:master", "urn:alm:descriptor:com.tectonic.ui:select:v1.29-alpha.b2f713a9"}
+	// +kubebuilder:validation:Enum=v1.28-latest;v1.28.0;v1.27-latest;v1.27.3;v1.27.2;v1.27.1;v1.27.0;v1.26-latest;v1.26.6;v1.26.5;v1.26.4;v1.26.3;v1.26.2;v1.26.1;v1.26.0;v1.25-latest;v1.25.5;v1.25.4;v1.25.3;v1.25.2;v1.25.1;v1.24-latest;v1.24.6;v1.24.5;v1.24.4;v1.24.3;v1.24.2;v1.24.1;v1.24.0;master;v1.29-alpha.b2f713a9


@dgn can you please take a close look at this change as well. This PR not only fixes the issue mentioned in the bug-1394, but it also updates the validation rules to include all supported versions in v1.24.x and v1.25.x (earlier the code was only allowing v1.24-latest and v1.25-latest, which seems to be a bug).

dgn

left a few comments, I think we can simplify a bit.

I also noticed that the $cniValues etc. variables aren't actually used for CNI but for istiorevisions, which is strange, but we can fix that separately

hack/update-version-list.sh

This PR includes the following changes. 1. Fixes an issue where the ZTunnel CRD included v1.25-latest and v1.24-latest. 2. Updates hack/update-version-list.sh so ztunnelversionsEnum is derived from versionsEnum while filtering out v1.21.x, v1.22.x, and v1.23.x. 3. Adds chart/samples/ztunnel-sample.yaml to updateVersionInSamples to keep all sample files in sync with version updates. Fixes: istio-ecosystem#1394 Signed-off-by: Sridhar Gaddam <[email protected]>

Signed-off-by: Sridhar Gaddam <[email protected]>

* upstream/main: Fix ztunnel version enumeration in update-version-list script (istio-ecosystem#1416) Update release process doc to reference up to date checklists (istio-ecosystem#1437) Running automator to update deps also for release branches (istio-ecosystem#1424) docs-test: improve logging (istio-ecosystem#1433) Add support for pinning tool versions to minor releases (istio-ecosystem#1421) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1428) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1427) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1426) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1425) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1422) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1413)

* upstream/main: tests: add junit reports for unit/integration/docs tests (istio-ecosystem#1439) Fix ztunnel version enumeration in update-version-list script (istio-ecosystem#1416) Update release process doc to reference up to date checklists (istio-ecosystem#1437) Running automator to update deps also for release branches (istio-ecosystem#1424) docs-test: improve logging (istio-ecosystem#1433) Add support for pinning tool versions to minor releases (istio-ecosystem#1421) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1428) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1427) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1426) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1425) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1422) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1413)

* upstream/main: Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1443) tests: add junit reports for unit/integration/docs tests (istio-ecosystem#1439) Fix ztunnel version enumeration in update-version-list script (istio-ecosystem#1416) Update release process doc to reference up to date checklists (istio-ecosystem#1437) Running automator to update deps also for release branches (istio-ecosystem#1424) docs-test: improve logging (istio-ecosystem#1433) Add support for pinning tool versions to minor releases (istio-ecosystem#1421) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1428) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1427) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1426) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1425) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1422) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1413)

* upstream/main: Fix sail operator api-reference links (istio-ecosystem#1448) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1443) tests: add junit reports for unit/integration/docs tests (istio-ecosystem#1439) Fix ztunnel version enumeration in update-version-list script (istio-ecosystem#1416) Update release process doc to reference up to date checklists (istio-ecosystem#1437) Running automator to update deps also for release branches (istio-ecosystem#1424) docs-test: improve logging (istio-ecosystem#1433) Add support for pinning tool versions to minor releases (istio-ecosystem#1421) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1428) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1427) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1426) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1425) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1422) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1413)

* upstream/main: Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1452) Fix sail operator api-reference links (istio-ecosystem#1448) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1443) tests: add junit reports for unit/integration/docs tests (istio-ecosystem#1439) Fix ztunnel version enumeration in update-version-list script (istio-ecosystem#1416) Update release process doc to reference up to date checklists (istio-ecosystem#1437) Running automator to update deps also for release branches (istio-ecosystem#1424) docs-test: improve logging (istio-ecosystem#1433) Add support for pinning tool versions to minor releases (istio-ecosystem#1421) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1428) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1427) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1426) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1425) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1422) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1413)

* upstream/main: Bump operator version to 1.29.0 (istio-ecosystem#1451) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1452) Fix sail operator api-reference links (istio-ecosystem#1448) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1443) tests: add junit reports for unit/integration/docs tests (istio-ecosystem#1439) Fix ztunnel version enumeration in update-version-list script (istio-ecosystem#1416) Update release process doc to reference up to date checklists (istio-ecosystem#1437) Running automator to update deps also for release branches (istio-ecosystem#1424) docs-test: improve logging (istio-ecosystem#1433) Add support for pinning tool versions to minor releases (istio-ecosystem#1421) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1428) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1427) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1426) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1425) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1422) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1413)

* upstream/main: Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1453) Bump operator version to 1.29.0 (istio-ecosystem#1451) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1452) Fix sail operator api-reference links (istio-ecosystem#1448) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1443) tests: add junit reports for unit/integration/docs tests (istio-ecosystem#1439) Fix ztunnel version enumeration in update-version-list script (istio-ecosystem#1416) Update release process doc to reference up to date checklists (istio-ecosystem#1437) Running automator to update deps also for release branches (istio-ecosystem#1424) docs-test: improve logging (istio-ecosystem#1433) Add support for pinning tool versions to minor releases (istio-ecosystem#1421) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1428) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1427) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1426) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1425) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1422) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1413)

* upstream/main: Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1457) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1453) Bump operator version to 1.29.0 (istio-ecosystem#1451) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1452) Fix sail operator api-reference links (istio-ecosystem#1448) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1443) tests: add junit reports for unit/integration/docs tests (istio-ecosystem#1439) Fix ztunnel version enumeration in update-version-list script (istio-ecosystem#1416) Update release process doc to reference up to date checklists (istio-ecosystem#1437) Running automator to update deps also for release branches (istio-ecosystem#1424) docs-test: improve logging (istio-ecosystem#1433) Add support for pinning tool versions to minor releases (istio-ecosystem#1421) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1428) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1427) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1426) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1425) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1422) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1413)

* upstream/main: Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1460) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1457) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1453) Bump operator version to 1.29.0 (istio-ecosystem#1451) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1452) Fix sail operator api-reference links (istio-ecosystem#1448) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1443) tests: add junit reports for unit/integration/docs tests (istio-ecosystem#1439) Fix ztunnel version enumeration in update-version-list script (istio-ecosystem#1416) Update release process doc to reference up to date checklists (istio-ecosystem#1437) Running automator to update deps also for release branches (istio-ecosystem#1424) docs-test: improve logging (istio-ecosystem#1433) Add support for pinning tool versions to minor releases (istio-ecosystem#1421) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1428) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1427) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1426) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1425) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1422) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1413)

sridhargaddam requested a review from a team as a code owner December 1, 2025 12:18

istio-testing added the size/M label Dec 1, 2025

sridhargaddam added the do-not-merge/hold label Dec 1, 2025

sridhargaddam commented Dec 1, 2025

View reviewed changes

sridhargaddam requested a review from dgn December 1, 2025 12:38

dgn reviewed Dec 1, 2025

View reviewed changes

hack/update-version-list.sh Outdated Show resolved Hide resolved

hack/update-version-list.sh Outdated Show resolved Hide resolved

hack/update-version-list.sh Outdated Show resolved Hide resolved

sridhargaddam requested a review from dgn December 1, 2025 17:38

istio-testing added the needs-rebase label Dec 4, 2025

sridhargaddam force-pushed the issue-1394 branch from 236742c to 61b4d54 Compare December 9, 2025 16:15

istio-testing removed the needs-rebase label Dec 9, 2025

dgn approved these changes Dec 10, 2025

View reviewed changes

istio-testing added the needs-rebase label Dec 10, 2025

sridhargaddam added 2 commits December 10, 2025 17:24

Address review comments

bc4241f

Signed-off-by: Sridhar Gaddam <[email protected]>

sridhargaddam force-pushed the issue-1394 branch from 61b4d54 to bc4241f Compare December 10, 2025 11:56

istio-testing removed the needs-rebase label Dec 10, 2025

sridhargaddam removed the do-not-merge/hold label Dec 10, 2025

istio-testing merged commit ea163e6 into istio-ecosystem:main Dec 10, 2025
17 of 19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix ztunnel version enumeration in update-version-list script #1416

Fix ztunnel version enumeration in update-version-list script #1416

Uh oh!

sridhargaddam commented Dec 1, 2025

Uh oh!

sridhargaddam commented Dec 1, 2025 •

edited

Loading

Uh oh!

codecov bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

sridhargaddam Dec 1, 2025

Uh oh!

dgn left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix ztunnel version enumeration in update-version-list script #1416

Fix ztunnel version enumeration in update-version-list script #1416

Uh oh!

Conversation

sridhargaddam commented Dec 1, 2025

Uh oh!

sridhargaddam commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sridhargaddam Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

dgn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sridhargaddam commented Dec 1, 2025 •

edited

Loading

codecov bot commented Dec 1, 2025 •

edited

Loading