-
Notifications
You must be signed in to change notification settings - Fork 575
Clarify Service Entry addresses behavior limitations #3549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
😊 Welcome @kfaseela! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
/retest |
// addresses are not supported in this field. Note that the `addresses` | ||
// API implies you can provide multiple addresses but there are limitations | ||
// on it (e.g.: you cannot set VIP addresses regardless of the combination of ip families). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a hard time understanding what this means. I think the clarification we wish to convey is that multiple VIPs will not be assigned to a single host, even though having a list suggests that might occur. As a result of this, you are not able to specify dual-stack VIPs using this field.
Signed-off-by: Faseela K <[email protected]>
77290a5
to
d4f64ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wording is clearer to my mind. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cherrypick release-1.27 |
@kfaseela: new pull request created: #3556 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Ref: istio/istio#34577