Skip to content

cherry-pick baseURL fix to istio.io #16662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

cherry-pick baseURL fix to istio.io #16662

wants to merge 1 commit into from

Conversation

craigbox
Copy link
Contributor

@craigbox craigbox commented Jul 14, 2025 •
edited
Loading

Manual cherry-pick of #16568.

@craigbox craigbox requested review from a team as code owners July 14, 2025 02:06
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jul 14, 2025
@istio-testing
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@istio-testing istio-testing added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 14, 2025
@craigbox craigbox changed the base branch from master to release-1.26 July 14, 2025 02:07
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 14, 2025
@istio-testing
Copy link
Contributor

@craigbox: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
lint_istio.io db90c50 link true /test lint
update-ref-docs-dry-run_istio.io db90c50 link false /test update-ref-docs-dry-run
gencheck_istio.io db90c50 link true /test gencheck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@craigbox
Copy link
Contributor Author

#16568 (comment) shows that the PR worked on preliminary, which uses the same context variable as istio.io (with a different URL variable.)

@craigbox
Copy link
Contributor Author

I don't think I can make the PR ignore the master tests having failed, so I'll open another one.

@craigbox craigbox closed this Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-rebase Indicates a PR needs to be rebased before being merged size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craigbox @istio-testing