Skip to content

cherry-pick baseURL fix to istio.io #16663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2025

Conversation

craigbox
Copy link
Contributor

Manual cherry-pick of #16568.

#16568 (comment) shows that the PR worked on preliminary, which uses the same context variable as istio.io (with a different URL variable.)

Second attempt; this time against the right base!

@craigbox craigbox requested a review from a team as a code owner July 14, 2025 02:11
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 14, 2025
@Ajay-singh1
Copy link
Member

Thanks! Craig.

@craigbox craigbox requested a review from dhawton July 14, 2025 03:03
@istio-testing istio-testing merged commit aa8a51a into istio:release-1.26 Jul 14, 2025
5 checks passed
@craigbox craigbox deleted the manual-cp-baseurl branch July 17, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants