-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Automated test case for istioctl install/uninstall #8688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@carolynhu: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@carolynhu The changes you need to make in the doc (index.md) to improve/support the test should be done in the same PR (this one). |
# | ||
|
||
snip_install_a_different_profile_1 | ||
_verify_like snip_check_whats_installed_1 snip_check_whats_installed_1_out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix bad variable syntax, here and throughout the test.
_verify_like snip_check_whats_installed_1 snip_check_whats_installed_1_out | |
_verify_like snip_check_whats_installed_1 "$snip_check_whats_installed_1_out" |
got it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any interest in coming back to this, @carolynhu ?
If not, @frankbu, do you think it worth fixing up, or is it out of date due to the Operator not being the preferred method any more?
WIP, needs to fix istio.io site first to make verify test pass.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure