Skip to content

Automated test case for istioctl install/uninstall #8688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carolynhu
Copy link
Contributor

@carolynhu carolynhu commented Dec 18, 2020

WIP, needs to fix istio.io site first to make verify test pass.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@carolynhu carolynhu requested a review from a team as a code owner December 18, 2020 00:50
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Dec 18, 2020
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 18, 2020
@carolynhu carolynhu added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Dec 18, 2020
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Dec 18, 2020
@istio-testing
Copy link
Contributor

@carolynhu: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
lint_istio.io fe4c088 link /test lint_istio.io
doc.test.profile_default_istio.io fe4c088 link /test doc.test.profile_default_istio.io
doc.test.profile_demo_istio.io fe4c088 link /test doc.test.profile_demo_istio.io
doc.test.profile_none_istio.io fe4c088 link /test doc.test.profile_none_istio.io
doc.test.multicluster_istio.io fe4c088 link /test doc.test.multicluster_istio.io

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu frankbu added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Dec 18, 2020
@frankbu
Copy link
Collaborator

frankbu commented Dec 18, 2020

needs to fix istio.io site first to make verify test pass.

@carolynhu The changes you need to make in the doc (index.md) to improve/support the test should be done in the same PR (this one).

#

snip_install_a_different_profile_1
_verify_like snip_check_whats_installed_1 snip_check_whats_installed_1_out
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix bad variable syntax, here and throughout the test.

Suggested change
_verify_like snip_check_whats_installed_1 snip_check_whats_installed_1_out
_verify_like snip_check_whats_installed_1 "$snip_check_whats_installed_1_out"

@carolynhu
Copy link
Contributor Author

needs to fix istio.io site first to make verify test pass.

@carolynhu The changes you need to make in the doc (index.md) to improve/support the test should be done in the same PR (this one).

got it!

Copy link
Contributor

@craigbox craigbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any interest in coming back to this, @carolynhu ?

If not, @frankbu, do you think it worth fixing up, or is it out of date due to the Operator not being the preferred method any more?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants