Skip to content

fix: exclude 429 from linter #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix: exclude 429 from linter #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d20ec7e
fix: exclude 429 from linter
jpkalbacher Dec 10, 2024
53e6691
wrap entire qualifying statement for error description
jpkalbacher Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions isp-rules.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,9 @@ rules:
# Errors must include a `detail` field
error-detail:
severity: error
description: Errors must be problem+JSON and include a "detail" field
given: $..responses.[?(@property.toString().startsWith("4") || @property.toString() === "500")]
# 429 returns from the API Gateway, so we exclude it
description: Errors must be problem+JSON or text/plain and include a "detail" field
given: $..responses.[?((@property.toString().startsWith("4") || @property.toString() === "500") && @property.toString() != "429")]
then:
- field: content
function: truthy
Expand Down
Loading