feat(ui/sim): change SIM icon colors in dark mode #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a color palette to map SIM icon colors in light mode to dark mode as in SIM rename dialog within builtin Settings app. Note that, Android 10/11 (SDK 29/30) didn't offer support for colors in dark mode, so we'd added them (material 300 code). Starting from Android 12 (SDK 31), we got support for colors in dark mode and a new color palette in SIM rename dialog within builtin Settings, but the Android OS framework still used the legacy colors until Android 14 (SDK 34), so we want to support them both.
… color array size
iusmac
force-pushed
the
feat-ui-sim-change-sim-icon-colors-in-dark-mode
branch
8 times, most recently
from
bb21da1 to
51d1091
Compare
iusmac
force-pushed
the
feat-ui-sim-change-sim-icon-colors-in-dark-mode
branch
3 times, most recently
from
03c4822 to
baafd68
Compare
For better test robustness, it's better to rely on framework constants than on our copy of the those constants. Note that, now that we use Android OS internal sim_colors array, we need to reorder our SIM color int array copy for SDK 34 (Android S+), so that the int values match 1-1 in order for the tests to pass.
iusmac
force-pushed
the
feat-ui-sim-change-sim-icon-colors-in-dark-mode
branch
from
baafd68 to
fc438da
Compare
java.util.NoSuchElementException: Array is empty. at kotlin.collections.ArraysKt___ArraysKt.first(_Arrays.kt:1073) at com.github.iusmac.sevensim.ui.sim.SimListActivityTest$SimEntries.test should use dark sim color palette whenever possible(SimListActivityTest.kt:837)
iusmac
force-pushed
the
feat-ui-sim-change-sim-icon-colors-in-dark-mode
branch
from
5d6f89c to
713c682
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a color palette to map SIM icon colors in light mode to dark mode as in SIM rename dialog within builtin Settings app.
Note that, Android 10/11 (SDK 29/30) didn't offer support for colors in dark mode, so we'd added them (material 300 code). Starting from Android 12 (SDK 31), we got support for colors in dark mode and a new color palette in SIM rename dialog within builtin Settings, but the Android OS framework still used the legacy colors until Android 14 (SDK 34), so we want to support them both.