Skip to content

Change video dimensions depending on orientation #2191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change video dimensions depending on orientation #2191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions ios/src/ImageCropPicker.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,16 @@ - (void) handleVideo:(AVAsset*)asset withFileName:(NSString*)fileName withLocalI
if (exportSession.status == AVAssetExportSessionStatusCompleted) {
AVAsset *compressedAsset = [AVAsset assetWithURL:outputURL];
AVAssetTrack *track = [[compressedAsset tracksWithMediaType:AVMediaTypeVideo] firstObject];

CGFloat width = track.naturalSize.width;
CGFloat height = track.naturalSize.height;
CGAffineTransform preferredTransform = track.preferredTransform;

// Adjust width and height if video is in portrait mode
if (preferredTransform.a == 0 && preferredTransform.b == 1.0 && preferredTransform.c == -1.0 && preferredTransform.d == 0) {
width = track.naturalSize.height;
height = track.naturalSize.width;
}

NSNumber *fileSizeValue = nil;
[outputURL getResourceValue:&fileSizeValue
Expand All @@ -448,8 +458,8 @@ - (void) handleVideo:(AVAsset*)asset withFileName:(NSString*)fileName withLocalI
withSourceURL:[sourceURL absoluteString]
withLocalIdentifier:localIdentifier
withFilename:fileName
withWidth:[NSNumber numberWithFloat:track.naturalSize.width]
withHeight:[NSNumber numberWithFloat:track.naturalSize.height]
withWidth:[NSNumber numberWithFloat:width]
withHeight:[NSNumber numberWithFloat:height]
withMime:@"video/mp4"
withSize:fileSizeValue
withDuration:[NSNumber numberWithFloat:milliseconds]
Expand Down