-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Refactor: Uniform optimization + javadoc #2528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🖼️ Screenshot tests have failed. The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests. 📄 Where to find the report:
✅ If you did mean to change things: ✨ If you are creating entirely new tests: Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar". See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information Contact @richardTingle (aka richtea) for guidance if required |
These screenshot test failures will be related to #2542 |
This PR refactors the
Uniform
class incom.jme3.shader
to improve code clarity, maintainability, and usage safety. Key changes include:setValue
.Objects.equals
.deleteNativeBuffers
with explanatory comments.These updates make the
Uniform
class easier to understand, safer to use, and better documented for both users and maintainers.