Skip to content

fix(ga4): never let exceptions bubble to callers #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(ga4): never let exceptions bubble to callers #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions packages/ga4/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,22 +345,25 @@ function bindEvents(trackingId: string) {
function track(trackingId: string, props?: IProps);
function track(props?: IProps);
function track(...args: any[]) {
const [trackingId, { type, event, debug }] = getArguments(args);
try {
const [trackingId, { type, event, debug }] = getArguments(args);

if (!trackingId) {
console.error('GA4: Tracking ID is missing or undefined');
if (!trackingId) {
console.error('GA4: Tracking ID is missing or undefined');
return;
}

return;
}
const queryParams = getQueryParams(trackingId, { type, event, debug });
const endpoint = window.minimalAnalytics?.analyticsEndpoint || analyticsEndpoint;

const queryParams = getQueryParams(trackingId, { type, event, debug });
const endpoint = window.minimalAnalytics?.analyticsEndpoint || analyticsEndpoint;
navigator.sendBeacon(`${endpoint}?${queryParams}`);

navigator.sendBeacon(`${endpoint}?${queryParams}`);
bindEvents(trackingId);

bindEvents(trackingId);

trackCalled = true;
trackCalled = true;
} catch (error) {
console.error('GA4: ', error);
}
}

/* -----------------------------------
Expand Down
13 changes: 13 additions & 0 deletions packages/ga4/tests/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,19 @@ describe('ga4 -> track()', () => {
expect(navigator.sendBeacon).not.toBeCalled();
});

it("doesn't ppopagate exceptions", () => {
const errorLogMock = jest.spyOn(console, 'error');
const testError = new Error('test error');

jest.spyOn(navigator, 'sendBeacon').mockImplementation(() => {
throw testError;
});

expect(() => track(trackingId)).not.toThrow();

expect(errorLogMock).toHaveBeenCalledWith('GA4: ', testError);
});

it('can be called directly with a tracking ID', () => {
track(trackingId);

Expand Down