Modification of source code to comply with C99 and C++11 standards #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion 'strchr' (a value of type "int" cannot be assigned to an entity of type "char const *")
…(a value of type "Widget *" cannot be used to initialize an entity of type "MenuEntry *")
…ned int*}' to 'long int*' (no instance of constructor "MenuValue<T>::MenuValue [with T=int32_t]" matches the argument list)
…" matches the argument list
…nally be static or external
…F303. Thanks to wocard2
Owner
|
Hi, thanks for all the work. I am a bit unsure what I am going to do with this PR because:
So I think I will leave this open for a couple of weeks, wait for me to find time to properly check it and merge it then. Sorry, the LCR is a very low priority item on my list right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prepare for using another toolchain, I tried to bring your source code as much as possible to the C99 and C++11 standards. Perhaps this will be interesting for you.