Skip to content

Conversation

@Et7f3
Copy link
Contributor

@Et7f3 Et7f3 commented Aug 12, 2019

This PR fix 2 bugs on windows and it is related to #199
It is enough for me to have https://atom.io/packages/ide-reason working on my computer

@Et7f3
Copy link
Contributor Author

Et7f3 commented Aug 12, 2019

I haven't fixed OCAMLLIB variable bug (I have set a global one as workaround) this is resolve in #199
and I don't understand why util/Commands.re change in #199 (maybe a nother bug I haven't seen) and didn't touch to test (maybe add one or fix them if they are present)

@Et7f3
Copy link
Contributor Author

Et7f3 commented Aug 12, 2019

Where is absify used ? Maybe there is other pieces of useless code.

@zetashift
Copy link

@Et7f3 you mean you set a global PATH variable as a workaround for the OCAMLLIB error?

Copy link
Owner

@jaredly jaredly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you do a test to see if the user is under cygwin?

@Et7f3
Copy link
Contributor Author

Et7f3 commented Aug 24, 2019

@zetashift No You can set env variable and I have done this
image
if you are on Windows: I open Windos menu type env
image

Should be change environnement variable or something else in english

image

then you can add key/pair value and set manually OCAMLLIB

@jaredly jaredly merged commit 53c99e9 into jaredly:master Sep 10, 2019
@jaredly
Copy link
Owner

jaredly commented Sep 10, 2019

thanks!

@Et7f3 Et7f3 deleted the windows branch September 25, 2019 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants