[NFC] Refactor the collective matmul #31367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_799974615
branch
from
11e36bf to
5d3156c
Compare
1. Make sure out_smem is allocated for the duration of the kernel. The previous code didn't fully await its usage before its scoped allocations expired, which is UB. 2. Deduplicate the bodies of all N loop steps (we're peeling off the first step, since it's the only one that does comms). PiperOrigin-RevId: 801825966
copybara-service
bot
force-pushed
the
test_799974615
branch
from
5d3156c to
a5f2a26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[NFC] Refactor the collective matmul
The previous code didn't fully await its usage before its scoped
allocations expired, which is UB.
first step, since it's the only one that does comms).