-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[export] Add backwards compatibility tests for v6. #33853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This is in preparation for the upcoming serialization version 6 (jax-ml#33597).
The serialization version v6 was introduced in jax-ml#33597. I have tested these manually for forward compatibility by cherry-picking this PR on a version of the code before v6.
Summary of ChangesHello @gnecula, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the robustness of JAX's export serialization by adding comprehensive backwards compatibility tests for serialization version 6. It ensures that exported JAX functions, particularly those dealing with memory space and sharding configurations, can be reliably deserialized and executed across different versions. The changes involve introducing new test data and refining the testing utilities to support these validations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds backward compatibility tests for serialization version 6. The changes include a new test for memory_space serialization, along with the corresponding test data for versions 5 and 6. Existing test data files for sharding are also updated with version 6 data. The test helper export_and_serialize is updated to support platforms and to generate cleaner filenames for new test data. The changes are well-structured, correct, and follow existing patterns in the codebase. I have no specific comments for changes.
mwhittaker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
The serialization version v6 was introduced in #33597.
I have tested these manually for forward compatibility by
cherry-picking this PR on a version of the code before v6.