Skip to content

Add a JAX config to disable the preemption service. #33903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a JAX config to disable the preemption service. #33903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions jax/_src/distributed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,15 @@
),
)

_ENABLE_PREEMPTION_SERVICE = config.bool_state(
name='jax_enable_preemption_service',
default=True,
help=(
"Enables the preemption service. See"
" multihost_utils.reached_preemption_sync_point for details."
),
)

class State:
process_id: int = 0
num_processes: int = 1
Expand Down Expand Up @@ -188,6 +197,8 @@ def shutdown(self):
self.service = None

def initialize_preemption_sync_manager(self):
if not _ENABLE_PREEMPTION_SERVICE.value:
return
if self.preemption_sync_manager is not None:
raise RuntimeError(
'Preemption sync manager should only be initialized once.')
Expand Down
5 changes: 4 additions & 1 deletion jax/experimental/multihost_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,10 @@ def should_save(step_id: int) -> bool:
return False
sync_manager = distributed.global_state.preemption_sync_manager
if sync_manager is None:
raise RuntimeError("Preemption sync manager has not been initialized.")
raise RuntimeError(
"Preemption sync manager has not been initialized. Make sure the"
" 'jax_enable_preemption_service' config is enabled."
)
return sync_manager.reached_sync_point(step_id)


Expand Down
Loading