cmake(android): skip linking -lpthread on Android #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaldwin
previously approved these changes
Aug 17, 2025
jbaldwin
reviewed
Aug 20, 2025
dobord
force-pushed
the
fix/skip_linking_pthread_on_android
branch
from
fa9c264 to
60746e4
Compare
I wonder if this implies there is still a race condition on this test, its been fixed multiple times already, or if there is something different on the platform which requires stronger guarantees on setting the return value edit: global timeout reached -> does that just imply the tests took too long to run here? |
jbaldwin
previously approved these changes
Sep 9, 2025
|
I think you'll need to rebase onto main or merge main into your branch, there was a ci change which now requires This change is awesome, I had no idea how much it would be to get the tests to actually run, but very nice job! |
On Android pthread symbols are provided by bionic libc; there is no separate libpthread. Adding -lpthread triggers a link error (-lpthread not found). Guard pthread linkage with (UNIX AND NOT ANDROID) and document the reason. Other UNIX platforms (Linux, *BSD) still link against pthread explicitly; no behavior change elsewhere.
Wrap find_package(OpenSSL) in a conditional to avoid resolving host libraries when prebuilt OpenSSL::SSL/OpenSSL::Crypto targets are injected (Android embedding). pthread linking remains skipped on Android where pthread is part of libc.
dobord
force-pushed
the
fix/skip_linking_pthread_on_android
branch
from
427ceb3 to
0a92910
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android pthread symbols are provided by bionic libc; there is no separate libpthread. Adding -lpthread triggers a link error (-lpthread not found).
Guard pthread linkage with (UNIX AND NOT ANDROID) and document the reason. Other UNIX platforms (Linux, *BSD) still link against pthread explicitly; no behavior change elsewhere.