Skip to content

fix: crash on null values from access long type #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
verasativa wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: crash on null values from access long type #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pandas_access/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ def _extract_dtype(data_type):
if data_type.startswith('double'):
return np.float_
elif data_type.startswith('long'):
return np.int_
# access CAN have null values on long type, @ pandas 0.24 int null suport is experimental, a float is safer for now.
Copy link

@behrenhoff behrenhoff May 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

float supports a smaller range than INT. This might be ok, but when dealing with IDs (which tend to use up the whole range of values), you will break code.

consider:

f = np.float_(1 << 53)
print(f)
f += 1
print(f)

(in case np.float_ is a 64 bit IEEE representation)

So this should at least be optional.

Copy link
Author

@verasativa verasativa May 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since pandas .24 there is a Int type (notice the caps on the I), which allows nulls ints. If you are willing to require .24+ (they are at .24.2 now), that will fix it for both cases.

return np.float_
else:
return None

Expand Down