set_alarm: Misc fixes and improvements #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
value_type was being set in `attr` but it wasn't set in `flags`.
the cast here seems dobious. the multiplication will take place in `unsigned int` and the cast only affects the _result_ and not the multiplication itself. which means that the high 32bits will remain zero and the shift will thus always produce zero as well. use UL suffix on the integer constant to ensure that the multiplication itself happens at `unsigned long`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a couple things going on in
set_alarmwhich seemed dubious. Here's a summary of the changes (additional context provided in commit message). Feel free to cherry-pick in case you don't agree with a certain commit.valuewas unused, remove it.value_typewas set inattrbut the necessary value_mask wasn't set onflags. So addXSyncCAValueTypetoflags.unsigned longinstead of casting the result (otherwise that expression would always result in 0).