feat: adapt hierarchy block manager for disagg PD. #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kang-Meng
changed the title
Kang-Meng
force-pushed
the
bugfix_kvcache_store
branch
5 times, most recently
from
c2ccbf0 to
bf0a83d
Compare
XuZhang99
changed the title
Kang-Meng
force-pushed
the
bugfix_kvcache_store
branch
3 times, most recently
from
5d08f1c to
1891d65
Compare
Kang-Meng
force-pushed
the
bugfix_kvcache_store
branch
from
1891d65 to
6a9e561
Compare
Kang-Meng
force-pushed
the
bugfix_kvcache_store
branch
from
b49552f to
97d2df6
Compare
Kang-Meng
changed the title
DragonFive
reviewed
Dec 18, 2025
| memcpy(hash_key, other.hash_key, MURMUR_HASH3_VALUE_LEN); | ||
| } | ||
|
|
||
| BlockTransferInfo& operator=(BlockTransferInfo&& other) { |
Collaborator
There was a problem hiding this comment.
add "return *this" is better
| dst_block_id = other.dst_block_id; | ||
| transfer_type = other.transfer_type; | ||
| memcpy(hash_key, other.hash_key, MURMUR_HASH3_VALUE_LEN); | ||
| } |
Collaborator
There was a problem hiding this comment.
add "return *this" is better
| std::shared_ptr<std::atomic<int32_t>> flag, | ||
| std::vector<std::shared_ptr<std::atomic<uint32_t>>>* prefetch_results) { | ||
| prefetch_results->reserve(dp_local_tp_size_); | ||
| flag->store(dp_local_tp_size_, std::memory_order_acquire); |
Collaborator
There was a problem hiding this comment.
Use relaxed/release to store is better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.