when converting sha1 hash to filename, use first 2 charactors as fold… #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er name for better performance
|
I think this is a good change and would be happy to merge if you can make it maintain backward compatibility. We'd either need to notice if the store uses the old schema and have a way to upgrade it or be able to work with a mixed-format store. Also, we can't just rip out "v1" parts without an upgrade path. |
|
Just uploaded the python script I used to update storage name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…er name for better performance
I am using git-pat to manage train data set (millions of files). Need to change file name to folder/filename to avoid stressing the OS file system out.