Skip to content

Conversation

lavigneer
Copy link

…atch the node label

Fixes #1014

Changes

This change adds a new flag for telling the operator to spawn the seed jobs agent with the EXCLUSIVE mode set such that it will only run builds for jobs that match its label.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

@brokenpip3
Copy link
Collaborator

Thanks, seems valid and complete, will take a look later this week :)

Also I'm switching the PR to ready-for-review so we can run the e2e tests in the mean time

@brokenpip3 brokenpip3 marked this pull request as ready for review November 26, 2024 22:39
@brokenpip3 brokenpip3 self-requested a review as a code owner November 26, 2024 22:39
@brokenpip3
Copy link
Collaborator

we are trying to merge #1037 this first so we can update the base that will used to make changes like this one ^

@github-actions github-actions bot added the stale label Feb 9, 2025
@github-actions github-actions bot closed this Feb 17, 2025
@brokenpip3 brokenpip3 reopened this Feb 17, 2025
@brokenpip3
Copy link
Collaborator

we can finally review this PR 🎉

are you able to add a test for this? it could be a bats or ginko ones, you choose, the important part is to cover this specific case with and without seedJobRestrictJobsToLabel

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Be able to set the seed-job-agent to "Only build jobs with label expression matching this node"

2 participants