Skip to content

Conversation

pulsecat
Copy link

There is a security issue when ComposedComponent appears for a second before redirect when the user is unauthenticated.

@jferrettiboke
Copy link
Owner

Hi @pulsecat. Thanks for your contribution.

Can you show some test cases for this? This should not happen because componentWillMount() and componentWillUpdate() are invoked immediately before rendering.

@pulsecat
Copy link
Author

hi @jferrettiboke,

It is what I observed on the client side. My React expertise isn't really good but I suspect that this.context.router.push('/') does not have immediate effect and the subsequent render occurred anyway.

@jferrettiboke
Copy link
Owner

I didn't see anything that you mentioned. Can you explain me your use case exactly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants