Skip to content

feat(langs): skip language selection when only one language is configured #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2025

Conversation

jarmex
Copy link
Contributor

@jarmex jarmex commented Jul 27, 2025

  • Automatically use the single configured language without prompting
  • Improves user experience by removing unnecessary selection step
  • Maintains existing behavior for multiple languages or no languages

…ured

- Automatically use the single configured language without prompting
- Improves user experience by removing unnecessary selection step
- Maintains existing behavior for multiple languages or no languages
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @jarmex, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the language selection process by introducing an optimization that automatically uses the single configured language, thereby removing an unnecessary user prompt. This enhancement improves the overall user experience for users with a single language setup, while maintaining the existing interactive selection for multi-language environments.

Highlights

  • User Experience Improvement: The system will now automatically select the language if only one language is configured, bypassing the interactive selection prompt and improving user flow.
  • Conditional Language Selection: Introduced a check to determine the number of configured languages. If exactly one language is found, it is immediately used without requiring user input.
  • Behavior Preservation: The existing language selection behavior for scenarios with multiple configured languages or no languages remains unchanged, ensuring backward compatibility.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the user experience by automatically selecting the language when only one is configured. The logic is sound, and the review includes a suggestion to ensure consistent callback execution.

@@ -17,6 +17,12 @@ function M.select_lang(callback)
return
end

-- If only one language is configured, use it directly
if #_langs == 1 then
callback(_langs[1])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To ensure consistent behavior, it's recommended to always invoke callbacks asynchronously. Wrap the direct callback invocation in vim.schedule() to avoid unexpected behavior due to synchronous execution in some code paths.

    vim.schedule(function()
      callback(_langs[1])
    end)

@jinzhongjia
Copy link
Owner

nice pr, thanks

@jinzhongjia jinzhongjia merged commit 5f5c4be into jinzhongjia:main Jul 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants