config: Respect shell quotations in split_name_and_args
#7609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veykril
force-pushed
the
veykril/push-woxmzpvkrxqp
branch
from
63f6445 to
7f9003b
Compare
yuja
approved these changes
Sep 30, 2025
| // Handle things like `EDITOR=emacs -nw` (TODO: parse shell escapes) | ||
| let mut args = s.split(' ').map(|s| s.to_owned()); | ||
| (args.next().unwrap().into(), args.collect()) | ||
| let mut parts = shlex::Shlex::new(s); |
There was a problem hiding this comment.
Maybe better to check had_error and fall back to original string (or space-separated args)? The command execution would be more likely to fail, and the user can notice the problem.
https://docs.rs/shlex/1.3.0/shlex/bytes/struct.Shlex.html#structfield.had_error
Veykril
force-pushed
the
veykril/push-woxmzpvkrxqp
branch
from
7f9003b to
186d00a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows using
$EDITOR,ui.editorand the like with spaces within the paths.Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)