Skip to content

Conversation

@higgsd
Copy link
Contributor

@higgsd higgsd commented Oct 8, 2025

It bugged me that only the op log used .ago(), and then I found a situation where I wasn't sure whether "1 day ago" meant 1.1 days ago or 1.9 days ago. IMHO, displaying absolute times should be the default for accuracy, unless the user wishes otherwise.

Grepping uncovered an SVG (and presumably corresponding PNG) that with op log content. I am not sure whether this demo content needs updating, and if so, how.

This probably introduces inconsistencies with webpage content as well?

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added/updated tests to cover my changes

@higgsd higgsd requested a review from a team as a code owner October 8, 2025 02:26
@yuja
Copy link
Contributor

yuja commented Oct 8, 2025

I personally don't use relative timestamps, but some folks prefer that. I don't think we can come up with the default which most people agree.

@higgsd
Copy link
Contributor Author

higgsd commented Oct 8, 2025

I personally don't use relative timestamps, but some folks prefer that. I don't think we can come up with the default which most people agree.

Understood that there will be no agreement. This is prime bikeshedding territory. My goal was just to make things consistent (all absolute). Happy to drop this if status quo is preferred.

@higgsd higgsd force-pushed the push-zprnktxvmtkt branch from 5a61c13 to 786b01c Compare October 8, 2025 14:13
@higgsd higgsd enabled auto-merge October 8, 2025 17:03
@higgsd higgsd force-pushed the push-zprnktxvmtkt branch from 786b01c to 490b34b Compare October 13, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants