view: allow setting tracked state to absent remote refs #7673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The next patch will allow setting tracked state to absent remote refs.
This will allow us to set up tracking state and push new bookmarks in two steps #7072. Absent tracked remote refs are deleted with the corresponding local ref. I originally considered this rule could be enforced by git::import/export_refs(), but it seemed weird if absent remote refs were left when the tracking local ref was deleted by user. Therefore, this invariant is ensured by the view API. Since "jj bookmark track" cannot track absent remote refs yet, this patch doesn't have UX changes that should be documented.
Since "tracked" state doesn't exist in Git, git::import_refs() should ignore absent->absent "changes". git::export_refs() just works because it compares only ref targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7072
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)