git: refactor update_git_ref(), don't suppress find_reference() errors
#8182
+75
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuja
force-pushed
the
push-plwyoryxxvtu
branch
from
d3dd088 to
ee3a463
Compare
move_git_ref() will be a bit more complicated to fix handling of existing annotated tags. A tag ref may point to an annotated tag object.
I also renamed git_repo_ref to git_ref because there aren't any other "git_ref" variables.
Since there should be no existing ref in Git, it's better to try creating a ref first.
yuja
force-pushed
the
push-plwyoryxxvtu
branch
from
ee3a463 to
cc4c70b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)