Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions jmespath.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,11 @@
return false;
}

// Ordering operators are only valid for numbers
function compareable(first, second) {
return (typeof first === 'number' && typeof second === 'number');
}

function isFalse(obj) {
// From the spec:
// A false value corresponds to the following values:
Expand Down Expand Up @@ -985,16 +990,16 @@
result = !strictDeepEqual(first, second);
break;
case TOK_GT:
result = first > second;
result = compareable(first, second) ? first > second : null;
break;
case TOK_GTE:
result = first >= second;
result = compareable(first, second) ? first >= second : null;
break;
case TOK_LT:
result = first < second;
result = compareable(first, second) ? first < second : null;
break;
case TOK_LTE:
result = first <= second;
result = compareable(first, second) ? first <= second : null;
break;
default:
throw new Error("Unknown comparator: " + node.name);
Expand Down
28 changes: 27 additions & 1 deletion test/compliance/boolean.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@
"False": false,
"Number": 5,
"EmptyList": [],
"Zero": 0
"Zero": 0,
"String": "foo",
"Null": null
},
"cases": [
{
Expand Down Expand Up @@ -198,6 +200,30 @@
{
"expression": "!!Zero",
"result": true
},
{
"expression": "String < Number",
"result": null
},
{
"expression": "Number < String",
"result": null
},
{
"expression": "Null < Number",
"result": null
},
{
"expression": "Number < Null",
"result": null
},
{
"expression": "Null < String",
"result": null
},
{
"expression": "String < Null",
"result": null
}
]
},
Expand Down