Add missing flow utils #201
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominictobias
commented
Oct 4, 2023
| typeof AuthMechanism, | ||
| $Keys<typeof AuthMechanism> | ||
| >; | ||
| export type AuthMechanismType1 = (typeof AuthMechanism)[$Keys< |
There was a problem hiding this comment.
Don't know what is adding parenthesis around (typeof AuthMechanism) but it's not breaking types 🤷♂️
|
P.S. Guards are also supported - https://flow.org/en/docs/types/type-guards/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the utils which were not converted from TS are now natively supported in Flow.
I had to update the spread test as you can see, using spread for inexact object types now fails: Flow Playground
new:
Pick: https://flow.org/en/docs/types/utilities/#toc-pick
Exclude: https://flow.org/en/docs/types/utilities/#toc-exclude
Extract: https://flow.org/en/docs/types/utilities/#toc-extract
now natively supported:
Omit: https://flow.org/en/docs/types/utilities/#toc-omit
Partial: https://flow.org/en/docs/types/utilities/#toc-partial
Required: https://flow.org/en/docs/types/utilities/#toc-required
this + default generic arguments are supported so don't need to be removed
replace deprecated $ElementType and $PropertyType with indexed access types T[K]
https://flow.org/en/docs/types/utilities/#toc-propertytype
https://flow.org/en/docs/types/utilities/#toc-elementtype