Skip to content

Adding missing regex escapes in parse.py preprocess_regex() function - Issue #142 #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding missing regex escapes in parse.py preprocess_regex() function - Issue #142 #144

wants to merge 1 commit into from

Conversation

croxarens
Copy link

@croxarens croxarens commented Oct 3, 2018 •
edited
Loading

This fix is fixing the Issue #142 for python > 3.6.
I run ./test.py all and everything went fine.

@croxarens croxarens closed this Oct 3, 2018
@croxarens croxarens reopened this Oct 3, 2018
@croxarens croxarens changed the title Add missing regex escapes - Issue #142 Adding missing regex escapes in parse.py preprocess_regex() function - Issue #142 Oct 3, 2018
skjortan23
skjortan23 approved these changes Apr 10, 2019
View reviewed changes
Copy link

@skjortan23 skjortan23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixed the problem for me. I have locally patched the library but please commit to the main branch.

@croxarens croxarens mentioned this pull request May 20, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@MAkcanca MAkcanca MAkcanca approved these changes

@skjortan23 skjortan23 skjortan23 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@croxarens @MAkcanca @skjortan23