[php] Capture variables used in arrow closure expressions #5571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml86
requested changes
Jul 8, 2025
joern-cli/frontends/php2cpg/src/test/scala/io/joern/php2cpg/querying/ClosureTests.scala
Show resolved
Hide resolved
joern-cli/frontends/php2cpg/src/main/scala/io/joern/php2cpg/astcreation/AstCreatorHelper.scala
Outdated
Show resolved
Hide resolved
joern-cli/frontends/php2cpg/src/main/scala/io/joern/php2cpg/astcreation/AstCreatorHelper.scala
Outdated
Show resolved
Hide resolved
ml86
approved these changes
Jul 16, 2025
TNSelahle
force-pushed
the
andrei/php-automatic-variable-capturing-in-lambda
branch
from
f30736d to
2249e94
Compare
Member
|
@ml86 please re-review. I've updated the branch and also successfully run integration and sptests for |
ml86
requested changes
Oct 28, 2025
joern-cli/frontends/php2cpg/src/test/scala/io/joern/php2cpg/querying/ClosureTests.scala
Outdated
Show resolved
Hide resolved
TNSelahle
force-pushed
the
andrei/php-automatic-variable-capturing-in-lambda
branch
from
2249e94 to
3c857a3
Compare
ml86
approved these changes
Oct 31, 2025
TNSelahle
deleted the
andrei/php-automatic-variable-capturing-in-lambda
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added capturing for variables used in arrow closure expressions. Variables used in arrow closures that are not parameters passed to the arrow closure automatically capture the value of the variable outside the arrow closure