Skip to content

Conversation

@cordu-dev
Copy link

Thank you for this interface. Great job :)
I made some improvements. Please check them out.

  • Add __init__.py files to be able to import the API from other python packages.
  • Add dynamic absolute path to shared lib.
  • Refactor to respect PEP8.

Cheers!

@w4-jonghoon
Copy link

LGTM

@hongbo-miao
Copy link

hongbo-miao commented Apr 19, 2019

When I tried to use johnbryanmoore/VL53L0X_rasp_python as a library in my code and met the error:

OSError: ../bin/vl53l0x_python.so: cannot open shared object file: No such file or directory

@Lucianovici's branch fixed the issue perfectly.

Thank you @Lucianovici so much!

@hongbo-miao hongbo-miao mentioned this pull request Apr 19, 2019
@cordu-dev
Copy link
Author

Well the file is here. Did you compile the api with make?

https://github.com/johnbryanmoore/VL53L0X_rasp_python#compilation

@hongbo-miao
Copy link

hongbo-miao commented Apr 19, 2019

@Lucianovici Sorry my comment was misunderstanding. Just updated the last comment. The branch works perfect for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants