Feature/add v8 support #111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the submission @hannojg we are looking at your changes right now. Sorry for the delay. |
|
There was somewhat an issue with that code when using it not with v8, it couldn’t find the imports of I remember correctly. (We don’t use threads anymore so i can‘t test)
|
|
Sounds good, we will test it both ways |
|
Can confirm this works on Android -- using this in our fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes this library compatible with V8 runtime for react native (https://github.com/Kudo/react-native-v8).
I am not sure whether there is a better implementation for doing the Hermes availability detection than I did. For me, it works using V8!
I made this based on #110, so this probably needs to be merged first.