Add dry-run execution plan support to runner CLI #3
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds dry-run execution plan support to the runner CLI, allowing users to validate scripts and preview execution configuration without actually running the script.
- Introduces a
--dry-runCLI flag for validating and previewing execution plans - Exposes execution plan details via new
get_execution_plan()method in ScriptRunner - Extends test coverage with unit and integration tests for dry-run functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| runner.py | Adds get_execution_plan() method to ScriptRunner, stores config_file and history_db_path fields, implements --dry-run CLI flag handling |
| tests/test_runner_core.py | Adds unit test for get_execution_plan() method, removes trailing whitespace |
| tests/test_integration.py | Adds integration test for CLI dry-run functionality via subprocess execution |
| if args.dry_run: | ||
| try: | ||
| runner.validate_script() | ||
| except Exception as exc: | ||
| logging.error(f"Dry-run validation failed: {exc}") | ||
| return 1 | ||
|
|
||
| plan = runner.get_execution_plan() | ||
| print("\nDRY-RUN: Execution plan (no script executed)") | ||
| for key, value in plan.items(): | ||
| print(f" {key}: {value}") | ||
| return 0 |
There was a problem hiding this comment.
Inconsistent exit pattern: Use sys.exit() instead of return to match the pattern used throughout the rest of the main() function. All other early exits in the function use sys.exit() (lines 8440, 8447, 8460, 8476, 8494, etc.).
| if args.dry_run: | ||
| try: | ||
| runner.validate_script() | ||
| except Exception as exc: | ||
| logging.error(f"Dry-run validation failed: {exc}") | ||
| return 1 | ||
|
|
||
| plan = runner.get_execution_plan() | ||
| print("\nDRY-RUN: Execution plan (no script executed)") | ||
| for key, value in plan.items(): | ||
| print(f" {key}: {value}") | ||
| return 0 |
There was a problem hiding this comment.
Dry-run execution plan may show incomplete configuration. The dry-run check occurs before CLI arguments like --monitor-interval (line 8524) and retry configuration (lines 8527-8544) are applied to the runner. This means the execution plan will display default values instead of user-specified values for these settings. Consider either:
- Moving the dry-run check after all configuration is applied, or
- Passing these additional arguments to the ScriptRunner constructor
Summary
--dry-runCLI option that validates scripts and prints an execution plan instead of runningTesting
Codex Task