fix infinite loop caused by comment regexp in htmltag module #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why comment regexp looks like this:
/<!--([^-]+|[-][^-]+)*-->/, maybe for some specific rules.But I found that
/<!--([^-]+|[-][^-]+)*-->/can't match something like this:<!-- a--z -->, which is obviously a html comment.More importantly, this regexp
/<!--([^-]+|[-][^-]+)*-->/may cause infinite loop and break down the browser.See my issue before.
I positioned the bug, but have no idea why this regexp should cause infinite loop.
I rewrite it to
/<!--[\s\S]*?-->/and make this pull request.