Skip to content

Conversation

dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Oct 5, 2025

Pull Request for Issue # .

Summary of Changes

  • Move from rollup to Rolldown (rust based)
  • Remove some unneeded dependencies: fs-extra, recursive-readdir, rimraf, @rollup/plugin-replace, @rollup/plugin-node-resolve, @rollup/plugin-commonjs
  • Move from the old @vue/compiler-sfc to the new @vitejs/plugin-vue
  • Adjust the media manager to not throw
  • bump the minimum node to 20.10.0 so we could use import json files directly
  • Drop dotenv as the newer node versions support this natively
  • Drop the individual browser version in the browser list and use the baseline widely available Explanation: When a web platform feature is implemented in every browser, it becomes Baseline Newly available. After 30 months, that feature then becomes Baseline Widely available, which is a threshold in which most websites can adopt features without compatibility concerns.
  • Rolldown provides it's own minifier but I kept esbuild for almost everything apart the media manager (for the initial testing, later on we would switch everything to Rolldown and get rid of esbuild, so one less dependency...)

Testing Instructions

Check out the 5.4-dev and run npm i. Make a copy of the media folder somewhere in your hd
Check out this PR and run npm i. Make a copy of the media folder somewhere in your hd
Compare the 2 folders

Actual result BEFORE applying this Pull Request

Everything works

Expected result AFTER applying this Pull Request

Everything works

Differencies

Screenshot 2025-10-05 at 7 05 33 PM Screenshot 2025-10-05 at 7 11 57 PM

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.4-dev labels Oct 5, 2025
@dgrammatiko dgrammatiko force-pushed the 5.4-dev/rolldown branch 2 times, most recently from 2e79e00 to 77d5b31 Compare October 5, 2025 17:10

<script>
import * as types from '../../../store/mutation-types.es6';
import translate from '../../../plugins/translate.es6'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the import order matter?

In this file it is before the mediabrowser... but in the next file it is after the mediabrowser...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in this case, the exports from each module is executed at a particular part of this file but not in series. The modules themselves are just delivering the callbacks so it doesn't matter if these are alphanumerically organized or not. The benefits of the dynamic languages (PHP, JS, Python).
There are cases that the import is important ie import './something.js';

@HLeithner HLeithner changed the base branch from 5.4-dev to 6.1-dev October 15, 2025 18:00
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 6.1-dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.4-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants