-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[5.4] Move to rolldown #46231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 6.1-dev
Are you sure you want to change the base?
[5.4] Move to rolldown #46231
Conversation
2e79e00
to
77d5b31
Compare
|
||
<script> | ||
import * as types from '../../../store/mutation-types.es6'; | ||
import translate from '../../../plugins/translate.es6' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the import order matter?
In this file it is before the mediabrowser... but in the next file it is after the mediabrowser...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in this case, the exports from each module is executed at a particular part of this file but not in series. The modules themselves are just delivering the callbacks so it doesn't matter if these are alphanumerically organized or not. The benefits of the dynamic languages (PHP, JS, Python).
There are cases that the import is important ie import './something.js';
77d5b31
to
c4b6db9
Compare
6d11359
to
e1984dc
Compare
This pull request has been automatically rebased to 6.1-dev. |
Pull Request for Issue # .
Summary of Changes
baseline widely available
Explanation: When a web platform feature is implemented in every browser, it becomes Baseline Newly available. After 30 months, that feature then becomes Baseline Widely available, which is a threshold in which most websites can adopt features without compatibility concerns.Testing Instructions
Check out the 5.4-dev and run npm i. Make a copy of the media folder somewhere in your hd
Check out this PR and run npm i. Make a copy of the media folder somewhere in your hd
Compare the 2 folders
Actual result BEFORE applying this Pull Request
Everything works
Expected result AFTER applying this Pull Request
Everything works
Differencies
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed