Skip to content

Conversation

brianteeman
Copy link
Contributor

Pull Request for Issue #46192 .

Summary of Changes

When mail is disabled on a site the NEW button is not present in the admin privacy request screen.

This PR adds an on screen message using the existing language string

Testing Instructions

Disable mail sending in global config and go the privacy request screen

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Signed-off-by: BrianTeeman <[email protected]>
@richard67
Copy link
Member

@Sulpher Please test this one here as it solves your issue, and when done, go to the PR in the issue tracker here https://issues.joomla.org/tracker/joomla-cms/46256 and use the blue "Test this" button at the top left corner to select your test result and submit. Thanks in advance.

@Sulpher
Copy link

Sulpher commented Oct 9, 2025

I have tested this item ✅ successfully on 6b233c0

Joomla 5.3.4. When Send Mail option is disabled, there is no NEW button in Administrator Panel > Privacy Contests > Requests.
After this PR I see this notification:

Information requests can't be created when sending mail is disabled.

All is clear and informative.
screenshot

alt


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46256.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 6b233c0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46256.

@richard67 richard67 changed the title [5.4] Privacy Request message when mail is disabled [5.4] Privacy Request message when mail is disabled Oct 10, 2025
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46256.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 10, 2025
@richard67 richard67 added this to the Joomla! 5.4.1 milestone Oct 10, 2025
@muhme
Copy link
Contributor

muhme commented Oct 17, 2025

✅ Final test before merge with JBT & PHP 8.1: No button / no message before and error message seen after applying PR with gh pr checkout 46256

@muhme muhme merged commit 80027ce into joomla:5.4-dev Oct 17, 2025
40 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 17, 2025
@muhme
Copy link
Contributor

muhme commented Oct 17, 2025

Thank you @brianteeman for your contribution. Thank you @Sulpher and @richard67 for testing.

@brianteeman brianteeman deleted the privacy_request branch October 17, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants