Skip to content

Conversation

@brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Oct 10, 2025

Pull Request for Issue # .

Summary of Changes

Corrects the americanisation of colour

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

color scheme

Expected result AFTER applying this Pull Request

colour scheme

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Corrects the americanisation of colour

Signed-off-by: BrianTeeman <[email protected]>
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.4-dev labels Oct 10, 2025
@richard67
Copy link
Member

I have tested this item ✅ successfully on 0607702

Code review.

Change is correct.

While we use American spelling for code names, e.g. variable or method names or keys of language string, the content should be British.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46264.

Copy link
Contributor

@tecpromotion tecpromotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brianteeman

@tecpromotion
Copy link
Contributor

I have tested this item ✅ successfully on 0607702


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46264.

@tecpromotion
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46264.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 10, 2025
@richard67 richard67 added this to the Joomla! 5.4.1 milestone Oct 10, 2025
@richard67 richard67 added the bug label Oct 10, 2025
@muhme
Copy link
Contributor

muhme commented Oct 17, 2025

✅ Final check before merge with grep -i '".*color.*"' administrator/language/en-GB/* language/en-GB/* before the PR the changed entries are found, with unpacking the PR full package the remaining places are OK as CSS or plugin-type:

aadministrator/language/en-GB/lib_joomla.ini:JLIB_DATABASE_ERROR_FUNCTION_FAILED="DB function failed with error number %s <br><span style=\"color: red;\">%s</span>"
administrator/language/en-GB/lib_joomla.ini:JLIB_JS_AJAX_ERROR_PARSE="A parse error has occurred while processing the following JSON data:<br><code style=\"color:inherit;white-space:pre-wrap;padding:0;margin:0;border:0;background:inherit;\">%s</code>"
administrator/language/en-GB/plg_fields_color.ini:PLG_FIELDS_COLOR_XML_DESCRIPTION="This plugin lets you create new fields of type 'color' in any extensions where custom fields are supported."
administrator/language/en-GB/plg_fields_color.sys.ini:PLG_FIELDS_COLOR_XML_DESCRIPTION="This plugin lets you create new fields of type 'color' in any extensions where custom fields are supported."
language/en-GB/lib_joomla.ini:JLIB_DATABASE_ERROR_FUNCTION_FAILED="DB function failed with error number %s <br><span style=\"color: red;\">%s</span>"
language/en-GB/lib_joomla.ini:JLIB_JS_AJAX_ERROR_PARSE="A parse error has occurred while processing the following JSON data:<br><code style=\"color:inherit;white-space:pre-wrap;padding:0;margin:0;border:0;background:inherit;\">%s</code>"

@muhme muhme merged commit 91d279c into joomla:5.4-dev Oct 17, 2025
40 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 17, 2025
@muhme
Copy link
Contributor

muhme commented Oct 17, 2025

Thank you @brianteeman for your contribution. Thank you @tecpromotion and @richard67 for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants